Don't reload the page when publishing/discarding a reply.

Review Request #4205 — Created June 5, 2013 and submitted

Information

Review Board
master

Reviewers

Don't reload the page when publishing/discarding a reply.

Publishing/discarding a reply to a review no longer reloads the review
request page. That was ugly and made it easy to lose your place on the
page, especially for large review requests.

Now, discarding just removes all the comments that were discarded, and
publishing turns all the draft comment entries into published comment
entries.

As part of this, I've also cleaned up a lot of the templating around
these comments. We used to have hacks to look for IDs starting with
"yourcomment", which was stupid. We also had other IDs sticking around.
None of those are needed anymore, nor are some classes, so they've all
been removed.
Tested discarding a newly created reply with a comment.

Tested discarding an existing reply with a comment from the page render.

Tested publishing in both of the above situations.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/static/lib/js/moment-2.0.0.min.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/templates/base.html
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
        reviewboard/static/rb/js/views/reviewReplyDraftBannerView.js
        reviewboard/static/rb/js/models/tests/reviewModelTests.js
        reviewboard/static/rb/js/views/reviewReplyEditorView.js
        reviewboard/static/rb/js/models/reviewReplyEditorModel.js
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/models/tests/reviewReplyEditorModelTests.js
        reviewboard/static/rb/js/views/tests/reviewReplyEditorViewTests.js
        reviewboard/static/rb/js/models/userSessionModel.js
        reviewboard/static/rb/js/models/reviewModel.js
        reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
chipx86
Review request changed
Status:
Completed