• 
      

    Move opcodes_with_metadata into a DiffOpcodeGenerator class.

    Review Request #4162 — Created May 24, 2013 and submitted

    Information

    Review Board
    release-1.7.x

    Reviewers

    Move opcodes_with_metadata into a DiffOpcodeGenerator class.
    
    This new class performs all the same functions as the original
    functions. Some of the code has been moved out into helper functions
    for organization issues, but the logic hasn't changed.
    
    This is part of an effort to clean up the diff viewer code and make it
    more extensible.
    All unit tests pass.
    
    Tested locally with some diffs I have that have moved content. Everything
    worked as expected.
    Description From Last Updated

    Col: 27 E261 at least two spaces before inline comment

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/diffviewer/opcode_generator.py
          reviewboard/diffviewer/tests.py
          reviewboard/diffviewer/diffutils.py
        Ignored Files:
      
      
    2. Show all issues
      Col: 27
       E261 at least two spaces before inline comment
      
    3. 
        
    chipx86
    1. I forgot the docstrings. Will be adding those soon.
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (188bf5c)