• 
      

    Introducing kgb, the spy agency for Python unit tests.

    Review Request #4159 — Created May 22, 2013 and submitted

    Information

    kgb
    master

    Reviewers

    kgb
    Introducing kgb, the spy agency for Python unit tests.
    
    kgb provides Jasmine-like spy functionality for Python unit tests. It
    makes it very easy to spy on functions, block access to them, reroute to
    fake functions, check on calls, and so on.
    
    This is a simple Python module with no dependencies. It's trivial to
    use, fully documented, and awesome.
    Wrote lots of unit tests for it, which pass.
    Description From Last Updated

    there's an extra "the" in here.

    daviddavid

    Can you swap the order of call_original and call_fake, just so the one that takes priority comes first?

    daviddavid

    Col: 80 E501 line too long (87 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (81 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (86 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (80 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (85 > 79 characters)

    reviewbotreviewbot

    Col: 1 E124 closing bracket does not match visual indentation

    reviewbotreviewbot

    Col: 80 E501 line too long (87 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (81 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (86 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (80 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (85 > 79 characters)

    reviewbotreviewbot

    Col: 1 E124 closing bracket does not match visual indentation

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          kgb/agency.py
          kgb/tests.py
          kgb/__init__.py
          kgb/contextmanagers.py
          kgb/spies.py
          setup.py
        Ignored Files:
          README.md
      
      
    2. kgb/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (87 > 79 characters)
      
    3. kgb/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (81 > 79 characters)
      
    4. kgb/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (86 > 79 characters)
      
    5. kgb/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (80 > 79 characters)
      
    6. kgb/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (85 > 79 characters)
      
    7. setup.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       E124 closing bracket does not match visual indentation
      
    8. 
        
    david
    1. 
        
    2. README.md (Diff revision 1)
       
       
      Show all issues
      there's an extra "the" in here.
    3. kgb/spies.py (Diff revision 1)
       
       
      Show all issues
      Can you swap the order of call_original and call_fake, just so the one that takes priority comes first?
    4. 
        
    chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          kgb/agency.py
          kgb/tests.py
          kgb/__init__.py
          kgb/contextmanagers.py
          kgb/spies.py
          setup.py
        Ignored Files:
          README.md
      
      
    2. kgb/tests.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (87 > 79 characters)
      
    3. kgb/tests.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (81 > 79 characters)
      
    4. kgb/tests.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (86 > 79 characters)
      
    5. kgb/tests.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (80 > 79 characters)
      
    6. kgb/tests.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (85 > 79 characters)
      
    7. setup.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       E124 closing bracket does not match visual indentation
      
    8. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed