Summary

Add support for self-hosted hosting services.

Review Request #4144 — Created May 12, 2013 and submitted May 14, 2013, 11:04 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add support for self-hosted hosting services.

Now, hosting services an be marked as "self-hosted," which will cause a
"Domain" field to show up for the service above the account entry. Many
of the functions now take a domain.

Accounts now take a domain as well, and we filter registered accounts by
the domain.

Bug trackers have the same sort of setup as well.

GitHub's had a few more changes added to it for cleanup to use the
hosting URL and to not duplicate so much code.

Unit tests were added for all of this.

Testing Done

Unit tests pass.

Tested this extensively with another change that makes use of this.

Issues

Description	From	Last Updated
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:03 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:03 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 9:41 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	May 12, 2013, 10:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:04 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:04 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	May 12, 2013, 10:04 p.m.
Why this? local_site_name is already defined.	david	May 12, 2013, 10:56 p.m.
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:57 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:57 p.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	May 12, 2013, 10:57 p.m.

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/models.py
    reviewboard/webapi/resources.py
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/admin.py
    reviewboard/hostingsvcs/evolutions/account_hosting_url.py
    reviewboard/scmtools/forms.py
    reviewboard/hostingsvcs/evolutions/__init__.py
    reviewboard/hostingsvcs/service.py
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:
    reviewboard/static/rb/js/repositoryform.js

reviewboard/scmtools/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Change Summary:

* Raise a KeyError when there are problems registering a hosting service.
* Fix a unit test. It wasn't passing the hosting_url.

Diff:

Revision 2 (+511 -108)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/models.py
	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py
	reviewboard/hostingsvcs/evolutions/__init__.py
	reviewboard/hostingsvcs/evolutions/account_hosting_url.py
	reviewboard/scmtools/admin.py
	reviewboard/scmtools/forms.py
	3 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/models.py
    reviewboard/webapi/resources.py
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/admin.py
    reviewboard/hostingsvcs/evolutions/account_hosting_url.py
    reviewboard/scmtools/forms.py
    reviewboard/hostingsvcs/evolutions/__init__.py
    reviewboard/hostingsvcs/service.py
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:
    reviewboard/static/rb/js/repositoryform.js

reviewboard/scmtools/forms.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

reviewboard/webapi/resources.py (Diff revision 2)

The issue has been resolved. Show all issues

Why this? local_site_name is already defined.

chipx86 May 12, 2013, 10:55 p.m.

Couldn't tell you. I wrote this a while back. Screwed up. Fixing it.

Change Summary:

Removed some unnecessary re-computation of local_site_name.

Diff:

Revision 3 (+506 -108)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/models.py
	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py
	reviewboard/hostingsvcs/evolutions/__init__.py
	reviewboard/hostingsvcs/evolutions/account_hosting_url.py
	reviewboard/scmtools/admin.py
	reviewboard/scmtools/forms.py
	3 more

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/models.py
    reviewboard/webapi/resources.py
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/admin.py
    reviewboard/hostingsvcs/evolutions/account_hosting_url.py
    reviewboard/scmtools/forms.py
    reviewboard/hostingsvcs/evolutions/__init__.py
    reviewboard/hostingsvcs/service.py
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:
    reviewboard/static/rb/js/repositoryform.js

reviewboard/scmtools/forms.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/scmtools/tests.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Ship it!

```
Ship It!
```

Status:: Completed