Summary

Add signals to notify when fetching/checking a file started/finished.

Review Request #4081 — Created April 27, 2013 and submitted April 27, 2013, 5:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add signals to notify when fetching/checking a file started/finished.

These signals can be used to hook up code to perform an operation when
fetching files or checking the existence of files, or when knowing when
those fetches/checks are complete.

Along with this, the file in diffutils that did time logging of the
fetch operation has been moved into Repository.get_file, in order to
standardize it.

Testing Done

All unit tests pass, including the new ones to check for the signal
emissions.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/tests.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/reviews/forms.py
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources.py
  Ignored Files:

So my next step from this is to add centralized caching, and also file existence caching. So, question there... Do you think it's valuable to have these signals emit even when we have the cached value to pull, or only when we actually have to do a fetch?

david April 27, 2013, 2:46 p.m.

Since I think we mostly want this to check timing, I wouldn't use the same signals when there's a cached version.

chipx86 April 27, 2013, 5:06 p.m.

Agreed. That's the conclusion I reached too.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (a0da8ca)