Summary

[WIP] Checklist extension

Review Request #4070 — Created April 21, 2013 and discarded May 9, 2013, 12:28 p.m.

Information

Owner

phoenixairs

Repository

rb-extension-pack

Branch

Bugs

Depends On

Reviewers

Groups

People

phoenixairs

Description

Work in progress for Checklist extension. Currently trying to get checklist working on own page (checklist.html). Will break up into sensical commits once I understand what's going on.

Testing Done

Issues

Description	From	Last Updated
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 21, 2013, 12:03 a.m.
Col: 35 W291 trailing whitespace	reviewbot	April 21, 2013, 12:03 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 21, 2013, 12:03 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 21, 2013, 12:03 a.m.
Col: 49 W292 no newline at end of file	reviewbot	April 21, 2013, 12:03 a.m.
Col: 2 W292 no newline at end of file	reviewbot	April 21, 2013, 12:03 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 21, 2013, 12:03 a.m.
Col: 5 W191 indentation contains tabs	reviewbot	April 21, 2013, 12:03 a.m.
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	April 21, 2013, 12:03 a.m.
Col: 25 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 33 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	April 21, 2013, 12:03 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 21, 2013, 12:03 a.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	April 21, 2013, 12:03 a.m.
Col: 50 W292 no newline at end of file	reviewbot	April 21, 2013, 12:03 a.m.
Col: 2 W292 no newline at end of file	reviewbot	April 21, 2013, 12:03 a.m.

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbchecklist/rbchecklist/admin_urls.py
    rbchecklist/rbchecklist/models.py
    rbchecklist/rbchecklist/extension.py
    rbchecklist/setup.py
    rbchecklist/rbchecklist/webapi/resources.py
    rbchecklist/rbchecklist/urls.py
    rbchecklist/rbchecklist/views.py
  Ignored Files:
    rbchecklist/rbchecklist/htdocs/js/views/checklistItemView.js
    rbchecklist/rbchecklist/htdocs/js/models/checklistItemModel.js
    rbchecklist/rbchecklist/templates/rbchecklist/configure.html
    rbchecklist/rbchecklist/htdocs/js/views/checklistItemInstanceView.js
    rbchecklist/rbchecklist/templates/rbchecklist/scripts.html
    .reviewboardrc
    rbchecklist/rbchecklist/htdocs/js/models/checklistModel.js
    rbchecklist/rbchecklist/htdocs/js/models/localStorage.js
    rbchecklist/rbchecklist/templates/rbchecklist/checklist.html
    rbchecklist/rbchecklist/htdocs/js/models/checklistItemInstanceModel.js
    rbchecklist/rbchecklist/models.pyc
    rbchecklist/rbchecklist/htdocs/js/models/checklist.js

rbchecklist/rbchecklist/admin_urls.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```
rbchecklist/rbchecklist/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbchecklist/rbchecklist/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 35
 W291 trailing whitespace
```
rbchecklist/rbchecklist/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
rbchecklist/rbchecklist/models.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbchecklist/rbchecklist/models.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbchecklist/rbchecklist/models.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 49
 W292 no newline at end of file
```
rbchecklist/rbchecklist/urls.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 2
 W292 no newline at end of file
```
rbchecklist/rbchecklist/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbchecklist/rbchecklist/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
rbchecklist/rbchecklist/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 25
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 33
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
rbchecklist/rbchecklist/webapi/resources.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 50
 W292 no newline at end of file
```
rbchecklist/setup.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 2
 W292 no newline at end of file
```

Status:: Discarded

rbchecklist/setup.py (Diff revision 1)