Summary

LDAP auth backend assumes things about how first and last names can be gathered.

Review Request #399 — Created May 27, 2008 and submitted

Information

Owner

jordansissel

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

first_name and last_name are gathered (currently) by space-splitting the 'cn' field. This is correct unless you don't have spaces in your 'cn' field at which point user creation fails.

I have switched to using displayName, but this is not a permanent fix. I might recommend something similar to LDAP_UID_MASK, but it is not likely as simple.

Testing Done

I tested this on my server by logging in with an unregistered user using the LDAP backend. The user creation was successful.

trunk/reviewboard/accounts/backends.py (Diff revision 1)

Are we guaranteed to have a displayName variable with spaces? Can this have the same problem as cn?

jordansissel June 6, 2008, 7:23 p.m.

IIRC, we should really be pulling first name from the 'givenName' field and the last name from the 'sn' (surname) field.

Thoughts?

chipx86 July 10, 2008, 9:14 p.m.

I don't know LDAP well enough. If that's standard and we can rely on it, sure.

david July 11, 2008, 7:32 a.m.

Looks like it's a standard.  I'll make this change and submit it.