2723: Show issue status in dashboard

Itz****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 22, 2014
2772, 2908
http://reviews.reviewboard.org/


What version are you running?

1.6.11

What's the URL of the page this enhancement relates to, if any?

http://demo.reviewboard.org/dashboard/

Describe the enhancement and the motivation for it.

Can we have an option of displaying open/close issues in the my dashboard section.
Another option in this page is to show the Status of the request should be visible.

What operating system are you using? What browser?

Linux. Chrome and Firefox

Please provide any additional information below.
#1 Itz****@gmai***** (Google Code) (Is this you? Claim this profile.)
Also, to add to the list, an option in the tickets to mark their priority such as Low, medium, high etc and then show them in dashboard with color coding, Red for high, green for medium and blue for low etc.
david
#2 david
  • +Show issue status in dashboard
david
#4 david
  • +Component-Dashboard
#5 matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
Just showing unresolved issues would be a significant improvement. Three column choices for unresolved, resolved, and total (or five, adding also fixed and dropped?) are fine, but for me lower priority.

Issue importance is a fine idea, but maybe best tracked as a separate report...
#6 raja****@gmai***** (Google Code) (Is this you? Claim this profile.)
Would it be fine to show the issue count in the format of (Unresolved / Total). That way, we show all the relevant information helping people to know what is the status of issue. Initially I was thinking of the format Unresolved / Resolved / Total, but you could derive the Resolved from the other 2 numbers. 
Also, I suppose you would need this in All Review Requests as well as my Dashboard. 
#7 matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
Personally I'm less interested in the number of total issues. But now that you mention it, two choices, either unresolved by itself, or '<unresolved> / <total>' would probably suffice for people that care about both.

(One reason is that I'd like the unresolved-only to special case '0' by being blank, and have some bright icon or at least colored text for non-zero, similar to how the 'ship it' column works, so that unresolved issues stand out.)

Is there a difference in column availability for the various list displays? I would have assumed not...
#8 er**@lisane******* (Google Code) (Is this you? Claim this profile.)
It would also suit me if this was integrated as part of the "ship it" column.  If a review has unresolved issues, show an X and the count of unresolved issues on a red background, otherwise show the checkmark and ship-it count on the green background.  This would provide one column which can give the status of the review request as far as a go/no-go decision.  If the review has neither open issues nor a "ship it", it could just be blank. 
chipx86
#10 chipx86
There's a couple scattered discussions on how issues and Ship Its should work, and there have been some long-term requests around changing how we do it. I'd like to get a thread going on reviewboard-dev to centralize this discussion. I'd appreciate all of you joining in on it.

Give me until tonight to get that thread going, and a design spec.
  • +Confirmed
#11 raja****@gmai***** (Google Code) (Is this you? Claim this profile.)
In addition to showing this in dashboard and review pages, Im assuming the webapi also needs to support this. In the patch currently being worked on, Ive added the "open issue" count when listing review_requests through /api/review-requests/[\d+]?. Also added a filter called "open-issues" that can be used when calling the /api/review-requests to get only issues that are open.  
#12 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
is it possible to access to this "patch currently being worked on" please?
it is on github?
#13 raja****@gmai***** (Google Code) (Is this you? Claim this profile.)
The patch is posted at http://reviews.reviewboard.org/r/3949/. The images there arent the greatest and Ive not incorporated the feedback related to the images yet. Also, this patch is about 2 months old(I think built against 1.7.6), so you might want to patch it against that version. If it doesnt work, I can try building it against the latest trunk on github
#14 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
Thank you Raja,

I've just check on our restore server (1.7.6) djblets 3948 patch + reviewboard 3949 patch + rb-site upgrade including issue_count_status added in SEQUENCE from reviews/evolutions/__init__.py

sometimes, total and remaining open counts are wrong, for the moment it appears only on issues created before migration

our #163 has Total:20 Open: 6 Resolved: 12 Dropped: 2
but in dashboard Open Issue displays 7/21


our #84 has Total:51 Open: 51 Resolved: 0 Dropped: 0
but in dashboard Open Issues displays 58/58
#15 raja****@gmai***** (Google Code) (Is this you? Claim this profile.)
It looks like the number of open issues is increased in both cases (7 instead of 6 in #163, thus pushing the total count also by 1 and 58 instead of 51). 

Ill investigate the reason for this but for the 2 review requests that are showing wrong counts, would it be possible to give me a breakdown of the reviews and the number of issues (if u can screenshot that masking the data, thats fine too) against the reviews. Its not really mandatory but might make my debugging slightly easier ;)

#16 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
I've found it but do not understand why
issue_status=O and issue_opened=0?
how can it happen?
#17 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
I've found when it happens.
if you create some comments only when you review diff, comment will be marked with issue_status NULL and opened_issue=0
when you edit your review before publishing and check box 'Open an issue', issue_status will be 'O' and opened_issue will remain to 0 :-(

I will create a bug report for it. So Raja, it is not an issue about this #2723 changes
#18 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
here is my bug report #2984
https://code.google.com/p/reviewboard/issues/detail?id=2984

If opened_issue value is more important than issue_status, so Raja, it means you should check opened_issue=1 and issue_status=O to count an open issue 

As this time, I do not see added value for opened_issue compared to issue_status=O|D|R but it might be one

Nicolas
#19 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
Hi Raja,

another thing that could be improved and discussed is all reviewrequest have their last_updated field changed (even when 3 new fields are computed).
I do not know whenever it is possible or not but it could be great if last_updated field is not changed during initialization of these fields (our database contains ~600 reqs)

Nicolas
david
#20 david
This is now done in master, and will ship in 2.0 beta 3
  • -Confirmed
    +Fixed
#21 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
So it looks this is implemented by
https://github.com/reviewboard/reviewboard/commit/890013874fa0cebb7de00276ec3cb0abbe98a709
and
https://github.com/reviewboard/reviewboard/commit/14e84ffcd3fcf4f24ddcf6054f24c7baf5ed65af

#22 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
I miss this one https://github.com/reviewboard/reviewboard/commit/e93a37a73dac7b5db06b6fbb47f4ba8236ac0b5c
#23 pablo******@55soci****** (Google Code) (Is this you? Claim this profile.)
In version 2.0.2 I get the correct numbers in the ship it! column when the review is in ship it, but the column is blank if the review has not the 'ship it', no matter how many open issues are there. I expected to see the number of open issues for the last case also.
chipx86
#24 chipx86
That doesn't sound right. Can you show a screenshot of the dashboard entry for that and the review request in question? You can also look in the database browser in the admin UI for that review request, and see what its open_issue_count field says.
#25 pablo******@55soci****** (Google Code) (Is this you? Claim this profile.)
I cannot longer reproduce that. Maybe I just got confused ... Thanks for the response, and my appologies.