This is a good first pass. After these changes (mostly stylistic) we should get the post-review support written and get the known issues fixed up.

Maybe place this last in the file. We don't tend to use these, but I'm not opposed to it. Might be nice to standardize on them.

The things we're importing should start on the same line as the "from ... import". We should be able to fit one or two per line. Then continue them on the next line, indented with the first thing we're importing.

Two blank lines here.

I don't think we want to throw an ImportError. We might want something, but I'd rather we introduce a RepositoryNotFound exception in scmtools/core.py and use that.

if "mtn: misuse: no file" in err:

This should include the path and revision as arguments.

Two blank lines here.

SCMTool subclasses tend to be the first class in the file. Not a big deal, but we should try to standardize on that.

Two blank lines here.

If "is binary" in self.lines[linenum]:

Blank line before the return.

Excess blank line we can get rid of.

Looking better.

This should return an SCMError of some sort. SCMError("Repository %s does not exist" % path) would probably work.

Call status "failure" like the other tools use. You can then squash the next few lines:

if not failure:
    return out

if "mtn: ...."

No ">= 0"

This should include the file and revision information, if they exist. (Provide as much as possible)

I've gotten tired of seeing this review request moulder here, so I've made the changes Christian asked for, listed the known limitations in a comment, and committed it. Hopefully someone else will come pick this up and finish it.