Summary

[WIP] Creating a ReviewDataGrid

Review Request #3927 — Created March 4, 2013 and discarded Aug. 2, 2013, 7:20 p.m.

Information

Owner

katkat

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is a work-in-progress for creating a ReviewDataGrid for displaying all the reviews that a user has done. To keep the testing simple for now I have the review grid being displayed in place of the usual grid of review requests on a user's page (see screenshot). Currently it only displays the review id (which is interesting since I was expecting this to be the review request id), which also links to the review itself, and the timestamp from when the review was posted.

What's next:
- go through the code currently used (mostly copied from the ReviewRequestDataGrid) and figure out what isn't necessary or should be changed
- add more columns
- Have this displaying on it's own rather than high-jacking the review request display

Testing Done

Files

Issues

Description	From	Last Updated
These will need to look more like tabs. More padding is required to make them larger targets.	mike_conley	March 29, 2013, 5:17 p.m.
The rule you wrote is affecting this link as well. You should make your rules specific to "Review Requests" and …	mike_conley	March 29, 2013, 5:17 p.m.
The curvature here will need to go away.	mike_conley	March 29, 2013, 5:17 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 17, 2013, 4:42 p.m.
Col: 19 E223 tab before operator	reviewbot	March 17, 2013, 4:42 p.m.
Col: 62 E261 at least two spaces before inline comment	reviewbot	March 17, 2013, 4:43 p.m.
Col: 63 E262 inline comment should start with '# '	reviewbot	March 17, 2013, 4:43 p.m.
Col: 24 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:07 p.m.
Col: 14 E221 multiple spaces before operator	reviewbot	March 17, 2013, 4:43 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:07 p.m.
Col: 48 E261 at least two spaces before inline comment	reviewbot	March 17, 2013, 4:44 p.m.
Col: 49 E262 inline comment should start with '# '	reviewbot	March 17, 2013, 4:44 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 17, 2013, 4:44 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 38 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 21 E262 inline comment should start with '# '	reviewbot	March 17, 2013, 4:45 p.m.
Col: 21 E261 at least two spaces before inline comment	reviewbot	March 17, 2013, 4:45 p.m.
Col: 64 W291 trailing whitespace	reviewbot	March 17, 2013, 4:45 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 41 E127 continuation line over-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:08 p.m.
Col: 24 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 24 E127 continuation line over-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 24 E127 continuation line over-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Reviews don't have local_ids. You can just use pk directly.	david	March 24, 2013, 6:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 17, 2013, 7:21 p.m.
Col: 64 W291 trailing whitespace	reviewbot	March 17, 2013, 7:21 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 41 E127 continuation line over-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2013, 7:16 p.m.
Col: 24 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
The review request ID is probably really worth including.	mike_conley	March 29, 2013, 5:17 p.m.
Col: 24 E127 continuation line over-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
The Ship It column should probably look like the one in the main dashboard, so it should be "Ship it!", …	mike_conley	March 29, 2013, 5:17 p.m.
Col: 24 E127 continuation line over-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
This can be removed, probably.	mike_conley	March 29, 2013, 5:17 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 24, 2013, 6:41 p.m.
These should be in alphabetical order, so please ReviewDataGrid before ReviewRequestDataGrid.	mike_conley	March 29, 2013, 5:17 p.m.
Col: 15 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
Col: 15 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
Col: 15 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	March 24, 2013, 6:41 p.m.
These should probably be added to the static/rb/css/reviews.less file. Inline CSS is something we try to avoid.	mike_conley	March 29, 2013, 5:17 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/datagrids.py
  Ignored Files:
    reviewboard/accounts/fixtures/test_users.json

reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 19
 E223 tab before operator
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 62
 E261 at least two spaces before inline comment
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 63
 E262 inline comment should start with '# '
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 24
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 14
 E221 multiple spaces before operator
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 48
 E261 at least two spaces before inline comment
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 49
 E262 inline comment should start with '# '
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E262 inline comment should start with '# '
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E261 at least two spaces before inline comment
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 64
 W291 trailing whitespace
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 41
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```

Quite a good idea to have a list of Sent Reviews! Looking forward to the up coming changes.

Change Summary:

ReviewDataGrid WIP update
    
Updated code based on ReviewBot review, but ignored the issues for 'continuation line under-indented for visual indent'. 
I also removed some unnecessary code and added more columns to the grid.

What's next:
- get the grid displaying on its own instead of where the review request grid appears
- filter reviews so that only base replies appear
- add some more columns and improve the 'ship it' column to be more like the one for review requests

Diff:

Revision 2 (+111 -6)

Show changes

	reviewboard/accounts/fixtures/test_users.json
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/datagrids.py
    reviewboard/reviews/managers.py
  Ignored Files:
    reviewboard/accounts/fixtures/test_users.json

reviewboard/reviews/datagrids.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 24
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 24
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 24
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 64
 W291 trailing whitespace
```
reviewboard/reviews/views.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 41
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```

Added Files:

reviewboard/reviews/datagrids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Reviews don't have local_ids. You can just use pk directly.
```

Change Summary:

The ReviewDataGrid now displays in a new page linked from the user page. This page otherwise looks the same as the regular user page.
The list now filters out replies.
Also removed code dealing with local_site.

Diff:

Revision 3 (+162 -3)

Show changes

	reviewboard/urls.py
	reviewboard/accounts/fixtures/test_users.json
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/templates/reviews/user_page.html

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/urls.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/datagrids.py
  Ignored Files:
    reviewboard/templates/reviews/user_page.html
    reviewboard/accounts/fixtures/test_users.json

reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 24
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 24
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 24
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/managers.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 15
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 15
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 15
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/views.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```

Added Files:

Fix it!

New user page with Review List

An issue was opened. Show all issues

These will need to look more like tabs. More padding is required to make them larger targets.

New user page with Review List

An issue was opened. Show all issues

The rule you wrote is affecting this link as well. You should make your rules specific to "Review Requests" and "Reviews".

New user page with Review List
An issue was opened. Show all issues
```
The curvature here will need to go away.
```
reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
The review request ID is probably really worth including.
```

reviewboard/reviews/datagrids.py (Diff revision 3)

An issue was opened. Show all issues

The Ship It column should probably look like the one in the main dashboard, so it should be "Ship it!", and have a graphic to indicate of a Ship it was given.

reviewboard/reviews/datagrids.py (Diff revision 3)
An issue was opened. Show all issues
```
This can be removed, probably.
```

reviewboard/reviews/views.py (Diff revision 3)

An issue was opened. Show all issues

These should be in alphabetical order, so please ReviewDataGrid before ReviewRequestDataGrid.

reviewboard/templates/reviews/user_page.html (Diff revision 3)

An issue was opened. Show all issues

These should probably be added to the static/rb/css/reviews.less file. Inline CSS is something we try to avoid.

Status:: Discarded