Summary

Fix --revision-range=SINGLE_COMMIT on git.

Review Request #3926 — Created March 2, 2013 and discarded Dec. 16, 2013, 9:47 p.m.

Information

Owner

nh2

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Fix --revision-range=SINGLE_COMMIT on git.

Before this, we would generate a diff with

    git diff SINGLE_COMMIT..CURRENT_HEAD

but this is not what was intended and what we write in the docs.
Now, we use

    git show SINGLE_COMMIT

to really only generate the diff of the given commit.

Testing Done

Things like `rbtools/postreview.py -n --revision-range=master^` work as expected now.

Issues

Description	From	Last Updated
git show is very different from git diff, and will provide a different sort of patch to Review Board. We …	chipx86	March 3, 2013, 11:09 a.m.
Using show breaks something with our parent diffs.	SM smacleod	March 5, 2013, 7:21 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/git.py
  Ignored Files:

Ship it!

This looks OK, but someone more familiar with RBTools and our SCM clients should probably give it a ship-it too.

mike_conley March 3, 2013, 10:27 a.m.

Also, great work, and thanks for the patch. :)

Fix it!

rbtools/clients/git.py (Diff revision 1)

An issue was opened. Show all issues

git show is very different from git diff, and will provide a different sort of patch to Review Board.

We should be using git diff only, with the appropriate arguments for diffing just the revision we want.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0c06e1a). Thanks!

Status:: Re-opened

Fix it!

This change breaks diff generation when using --parent. I've reverted the change in master (9cd8d411e0b754e1653de765659573417d21880d)

rbtools/clients/git.py (Diff revision 1)
An issue was opened. Show all issues
```
Using show breaks something with our parent diffs.
```

Status:: Discarded