Summary

Factor out saving a PIL Image to django storage.

Review Request #3903 — Created Feb. 21, 2013 and submitted Feb. 21, 2013, 10:18 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Factor out saving a PIL Image to django storage.

Both the thumbnail and crop template tags do the same thing for taking a PIL
Image and saving it to a (potentially remote) storage. In addition, I need this
functionality in $SECRET_PROJECT, so I've factored it out into its own method.

Testing Done

Used this in $SECRET_PROJECT.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/templatetags/djblets_images.py
  Ignored Files:

Ship it!

djblets/util/templatetags/djblets_images.py (Diff revision 1)

Everything looks fine, but I'm curious, while you're in here... Any way we can chain the two together so we don't need the temp file?

david Feb. 21, 2013, 9:57 p.m.

I had initially tried to make this work with StringIO but it seems to need a real file object.

Status:: Completed
Change Summary:: Pushed to master (db4d760).