• 
      

    Put a clickable overlay on top of file attachment thumbnails.

    Review Request #3844 — Created Feb. 5, 2013 and submitted

    Information

    Review Board
    release-1.7.x

    Reviewers

    Put a clickable overlay on top of file attachment thumbnails.
    
    File attachment thumbnails can theoretically include HTML with links (for
    example, markdown or restructured text types). In these cases, wrapping the
    thumbnail in a big <a> tag isn't sufficient to make sure everything links to the
    review UI. This change puts a new block element on top of the thumbnail contents
    for users to click on.
    Uploaded a variety of file attachments, through both drag-and-drop and the 
    upload dialog. Checked that the overlay was clickable and covered any links 
    present in the thumbnail element.
    Description From Last Updated

    Since this has to match up with .file-thumbnail, maybe create a rule with both that has the attributes in common …

    chipx86chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/reviews.js
          reviewboard/static/rb/css/reviews.less
          reviewboard/templates/reviews/review_request_box.html
      
      
    2. 
        
    chipx86
    1. 
        
    2. reviewboard/static/rb/css/reviews.less (Diff revision 1)
       
       
      Show all issues
      Since this has to match up with .file-thumbnail, maybe create a rule with both that has the attributes in common (max-width, max-height, etc.)
    3. 
        
    david
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/reviews.js
          reviewboard/static/rb/css/reviews.less
          reviewboard/templates/reviews/review_request_box.html
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (3a70535).