Summary

Fix exception being thrown on URLs with nonexistent review id

Review Request #3767 — Created Jan. 18, 2013 and submitted Jan. 19, 2013, 12:56 p.m.

Information

Owner

nh2

Repository

Djblets

Branch

master

Bugs

2551

Depends On

Reviewers

Groups

djblets

People

Description

Fix exception being thrown on URLs with nonexistent review id

URLs like /api/review-requests/<id>/screenshots, where <id> is nonexistent, until now threw an exception instead of translating to a proper 404.

This change catches the possible ObjectDoesNotExist of get_queryset() in WebAPIResource.get_list.

Fixes #2551.

Testing Done

webapi.tests.ScreenshotResourceTests.test_get_screenshots_with_invalid_review_request_id in the corresponding change for revieboard tests this behavior.

Issues

Description	From	Last Updated
We like these alphabetically ordered- so this should be before django.core.urlresolvers.	mike_conley	Jan. 18, 2013, 4:56 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/webapi/resources.py
  Ignored Files:

Bugs:: 2551

djblets/webapi/resources.py (Diff revision 1)

The issue has been resolved. Show all issues

We like these alphabetically ordered- so this should be before django.core.urlresolvers.

Change Summary:

Fix import order

Diff:

Revision 2 (+14 -2)

Show changes

djblets/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/webapi/resources.py
  Ignored Files:

Change Summary:: Improve description
Summary:: WebAPIResource.get_list: Handle get_queryset() exception.
Fix exception being thrown on URLs with nonexistent review id
Description:: ~
WebAPIResource.get_list: Handle get_queryset() exception.
~
Fix exception being thrown on URLs with nonexistent review id

~
It can throw a ObjectDoesNotExist that now translates to a 404.
~ Fixes #2551.
~
URLs like /api/review-requests/<id>/screenshots, where <id> is nonexistent, until now threw an exception instead of translating to a proper 404.
~
+
This change catches the possible ObjectDoesNotExist of get_queryset() in WebAPIResource.get_list.
+
+
Fixes #2551.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0de0062). Thanks!

~		WebAPIResource.get_list: Handle get_queryset() exception.
	~	Fix exception being thrown on URLs with nonexistent review id

~		It can throw a ObjectDoesNotExist that now translates to a 404.
~		Fixes #2551.
	~	URLs like /api/review-requests/<id>/screenshots, where <id> is nonexistent, until now threw an exception instead of translating to a proper 404.
	~
	+	This change catches the possible ObjectDoesNotExist of get_queryset() in WebAPIResource.get_list.
	+
	+	Fixes #2551.