Summary

Fixed the SMTP whitespace big. SMTP address with whitespaces are now stripped properly.

Review Request #3759 — Created Jan. 18, 2013 and submitted Jan. 18, 2013, 4:38 p.m.

Information

Owner

ayrus

Repository

Review Board

Branch

master

Bugs

2620

Depends On

Reviewers

Groups

reviewboard

People

Description

Fixed the SMTP whitespace big. SMTP address with whitespaces are now stripped properly.

Testing Done

Produced the bug with an smtp server "smtp.gmail.com     " and triggered an email event (registration for new user). Log produced an error: "Unknown host". Added the changes on the diff and tried again, the email is sent and the value that is saved is stripped of the redudant spaces.

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 18, 2013, 4:19 p.m.
Col: 51 W291 trailing whitespace	reviewbot	Jan. 18, 2013, 4:19 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/forms.py
  Ignored Files:

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 51
 W291 trailing whitespace
```

Diff:

Revision 2 (+4)

Show changes

reviewboard/admin/forms.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/forms.py
  Ignored Files:

What testing did you do? Can you fill out the "Testing done" field with that?

AY

ayrus Jan. 18, 2013, 4:26 p.m.
```
Added above.
```

Testing Done:: +
Produced the bug with an smtp server "smtp.gmail.com " and triggered an email event (registration for new user). Log produced an error: "Unknown host". Added the changes on the diff and tried again, the email is sent and the value that is saved is stripped of the redudant spaces.

Ship it!

```
Ship It!
```

Bugs:: 2620

Status:: Completed
Change Summary:: Pushed to release-1.7.x (e6e5d07). Thanks!

reviewboard/admin/forms.py (Diff revision 1)

reviewboard/admin/forms.py (Diff revision 1)