Summary

RB info

Review Request #3733 — Created Jan. 9, 2013 and discarded April 23, 2014, 3:54 p.m.

Information

Owner

mw_triad

Repository

RBTools

Branch

api

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

A command to query resource attributes. At the moment, this only supports review requests, and is not able to list available attributes. (If there is a sane way to do this with the current state of the API, I have not been able to determine what it is.)

Args: rbt info <resource_selector> <attribute>
Options: --request (resource id)



git branch 'rbt-info' (9e79e3564450) available at git://github.com/mwoehlke/rbtools.git, and includes merge of latest master (not represented here). There is no .gitlog in the commit; it is an artifact of using 'git rb post' to upload this request.

Testing Done

'rbt info -r <num> <attribute>' for e.g. status, summary, description, on Linux.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 9, 2013, 2:47 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 9, 2013, 2:47 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	Jan. 9, 2013, 2:47 p.m.
Col: 47 E702 multiple statements on one line (semicolon)	reviewbot	Jan. 9, 2013, 2:47 p.m.
Col: 27 E261 at least two spaces before inline comment	reviewbot	Jan. 9, 2013, 2:47 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/rbinfo.py
    setup.py
  Ignored Files:

rbtools/commands/rbinfo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/commands/rbinfo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/commands/rbinfo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
rbtools/commands/rbinfo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 47
 E702 multiple statements on one line (semicolon)
```
rbtools/commands/rbinfo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 27
 E261 at least two spaces before inline comment
```

Change Summary:

Fixed issues flagged by Review Bot.

Branch:

api

master

Diff:

Revision 2 (+80 -59)

Show changes

	setup.py
	rbtools/commands/rbinfo.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
    rbtools/commands/rbinfo.py
  Ignored Files:

```
aaaa
```

Change Summary:

Update for latest changes in api branch, plus minor improvements.

Summary:

implement 'rb info' command

RB info

Description:

~		Rewrite rbinfo.py to actually do something useful (I was unable to get the old one to even run; it looks like it was written to an older version of the API?) This is still technically a work in progress, but one can do things like 'rb info -r <num> summary' and get the review request summary.
	~	A command to query resource attributes. At the moment, this only supports review requests, and is not able to list available attributes. (If there is a sane way to do this with the current state of the API, I have not been able to determine what it is.)
	+
	+	Args: rbt info <resource_selector> <attribute>
	+	Options: --request (resource id)
	+
	+
	+
	+
	+
	+	git branch 'rbt-info' (9e79e3564450) available at git://github.com/mwoehlke/rbtools.git, and includes merge of latest master (not represented here). There is no .gitlog in the commit; it is an artifact of using 'git rb post' to upload this request.

Testing Done:

~		'rb info -r <num> <attribute>' for e.g. status, summary, description, on Linux.
	~	'rbt info -r <num> <attribute>' for e.g. status, summary, description, on Linux.

Branch:

master

api

Diff:

Revision 3 (+103)

Show changes

	.gitlog
	setup.py
	rbtools/commands/info.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/info.py
    setup.py
  Ignored Files:
    .gitlog

Status:: Discarded

rbtools/commands/rbinfo.py (Diff revision 1)

rbtools/commands/rbinfo.py (Diff revision 1)

rbtools/commands/rbinfo.py (Diff revision 1)

rbtools/commands/rbinfo.py (Diff revision 1)