2833: post-review needs to override git diff.renames option

matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
Jan. 8, 2013
What version are you running?
RBTools 0.4.2

What steps will reproduce the problem?
1. git config diff.rename copies
2. Try to post a request in which git diff detects copies

What is the expected output? What do you see instead?
Uploading diff fails.

Please provide any additional information below.
clients/git.py needs to add '--no-renames' to git diff arguments to avoid automatic copy detection specified by user config.
david
#1 david
  • +Component-RBTools
#2 matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
This is fixed as of bacdab01f33; can someone with adequate permissions please close?
david
#3 david
  • +Fixed
#4 orse*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I could not find the change bacdab01f33 and clients/git.py  - What am I missing here?
#5 matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
https://github.com/reviewboard/rbtools/commit/bacdab01f33c75911d03a49ff0115d9d99287a82?