Summary

rb --help now displays all available commands.

Review Request #3690 — Created Dec. 20, 2012 and discarded Aug. 2, 2013, 12:23 p.m.

Information

Owner

cupcicm

Repository

RBTools

Branch

api

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

rb --help now displays all available commands.

And the error message on invalid commands is somewhat easier to
understand.

Note that I just thought that this feature was useful, but I am definitely OK if you don't want to implement it, or if you want to implement it your way down the road. Just discard the request, no problem.

Testing Done

Tested manually with valid and invalid command names.

Issues

Description	From	Last Updated
I think it's fine to just call pkg_resources.get_entry_map directly where it's needed. I don't see any other cases where this …	chipx86	Jan. 3, 2013, 11:40 p.m.
No space before :	chipx86	Jan. 3, 2013, 11:40 p.m.
You can just do: if command_name not in commands: It prevents having to build a list of keys.	chipx86	Jan. 3, 2013, 11:40 p.m.
No space before :	chipx86	Jan. 3, 2013, 11:40 p.m.

Fix it!

rbtools/commands/rb.py (Diff revision 1)

An issue was opened. Show all issues

I think it's fine to just call pkg_resources.get_entry_map directly where it's needed. I don't see any other cases where this function is used.

rbtools/commands/rb.py (Diff revision 1)
An issue was opened. Show all issues
```
No space before :
```

rbtools/commands/rb.py (Diff revision 1)

An issue was opened. Show all issues

You can just do:

if command_name not in commands:

It prevents having to build a list of keys.

rbtools/commands/rb.py (Diff revision 1)
An issue was opened. Show all issues
```
No space before :
```

I have a review request up now which is doing something similar, but we will be moving away from this down the line.

If it's simpler for you, I could just discard this request.
Or I can fix it, no problem.
I'll let you guys choose and tell me.

Status:: Discarded