Summary

Modify post-review to support review-board deployment under a directory instead of the root path

Review Request #369 — Created May 4, 2008 and submitted

Information

Owner

eliast

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

I deployed a test review-board server under /reviewboard by modifying SITE_ROOT but all of the API calls in post-review were being resolved by urljoin to the root even when REVIEWBOARD_URL included the directory. After making these changes, everything still resolved fine when not using a directory.

Testing Done

I posted this review to this board not deployed under a directory using these changes.

/trunk/reviewboard/contrib/tools/post-review (Diff revision 1)

I'm afraid I don't know how to add just a comment to this review (without referencing a specific line number of the diff).

Anyway, a similar patch was already submitted for review: http://reviews.review-board.org/r/360/ .  It would be nice if the changes mentioned in these reviews could be committed sometime soon, regardless of whether there are specific implementation details which might be more useful later on.  If that is the case (see the other review for details), then these changes can be made later on when they are important.