Summary

Improve the styling of the repository confirmation banners.

Review Request #3647 — Created Dec. 10, 2012 and submitted Dec. 12, 2012, 11:59 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Improve the styling of the repository confirmation banners.

The repository confirmation banners (cert/SSH key confirmations), plus
the public SSH key display, were ugly in the new UI. They appeared as
rounded things just kind of stuck there in the form.

This change blends them in much nicer, making them actually feel like
part of the form.

While I was at it, I also improved the SSH key display by adding the key
type at the beginning (which services like GitHub require).

Testing Done

Checked each banner type. They all looked fine.

Files

Issues

Description	From	Last Updated
It seems like there's a lot of extra padding on the bottom...	david	Dec. 12, 2012, 2:51 a.m.

SSH key banner

It seems like there's a lot of extra padding on the bottom...

The issue has been dropped. Show all issues

It seems like there's a lot of extra padding on the bottom...

chipx86 Dec. 10, 2012, 11:11 a.m.

This is using a textarea for display, so you can do things like right-click and choose "Select All" without it interfering with the page. Same pattern used in the SSH Key settings page and on RBC.

I can look into whether we can use autoSizeTextArea on this.

chipx86 Dec. 12, 2012, 2:51 a.m.

Okay, so basically, for a few reasons, that doesn't work well. Mainly, it's one long string, and nothing handles that well except a textarea.

I think we're going to have to live with this for now. We can make it smaller, but then it may scroll. This number seems to be a good compromise for different widths and public key lengths.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (4ede95a)