Summary

skip a deleted empty file during git diff parsing

Review Request #363 — Created April 20, 2008 and submitted

Information

Owner

trickie

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

So now the git parser will skip differences for:

 * new files with no content
 * file mode content with no content changes
 * deleted files with no content

It would be good to see those, but it barfs when trying to apply the empty diffs.

Testing Done

Git scmtool tests pass

Expand All
Collapse All

trunk/reviewboard/scmtools/git.py (Diff revision 2)

Now that this is in parentheses, you don't need the continuation marks (\).  In fact, it's better python style to use () instead of \ in general.

TR

trickie April 21, 2008, 5:14 p.m.
```
updated!
```

david April 22, 2008, 5:28 a.m.

Looks good.  Committed as r1309.  Thanks!