RB Patch (webapi modification)

 






 

 


  Review Request #3593
  —
  Created Nov. 30, 2012 and submitted 

 


















 

  

   Information

  





 
 

  jsintal
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Small change to the DiffSet in DiffResource to expose the 'basedir' to the webapi.
Used for my 'RB Patch' http://reviews.reviewboard.org/r/3440/

 








  


 
 

  
Accessed the field on an SVN DiffResource on dev server.

 







 









 





  








 









 






  

 








 














 



 

  

   





 JS





   

   

  

 



 















 



 

  

   





 JS





   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    So the code looks fine, but the summary and description really should be talking about this change, not your other change. For future changes, try to make the summary and description very clear so we can more easily scan our dashboard and know what it's about.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 JS





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-1.7.x (affb896)