This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-1.7.x (793c1cf).

Summary

Add review-ui URL field to FileAttachmentResource.

Review Request #3576 — Created Nov. 27, 2012 and submitted 12 years, 6 months ago

Information

Owner

david*

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

Add review-ui URL field to FileAttachmentResource.

In order to properly link to the review UIs when adding file attachments through
javascript, I need to have a URL. If the given attachment doesn't have a review
UI, this URL will just be an empty string.

Testing Done

Set a breakpoint in the javascript that runs after a file attachment succeeds
and looked at the resulting object.

Issues

Description	From	Last Updated
Probably should use obj.pk	chipx86	12 years, 6 months ago
Blank line between these.	chipx86	12 years, 6 months ago
There are no open issues

Ship it!

```
Two small things.
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably should use obj.pk
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (793c1cf).