• 
      

    Add a fallback encoding conversion for diff content.

    Review Request #3528 — Created Nov. 17, 2012 and submitted

    Information

    Review Board
    release-1.6.x

    Reviewers

    Add a fallback encoding conversion for diff content.
    
    When trying to convert the resulting diff content to unicode, we first try
    straight utf-8, and then try any encodings which were configured on the
    repository. This change adds one additional step, where we try to interpret the
    file as utf-8 but replace any unknown characters with U+FFFD.
    Ran unit tests.
    Description From Last Updated

    Probably should be one statement.

    chipx86chipx86

    Can just be one statement.

    chipx86chipx86
    chipx86
    1. 
        
    2. reviewboard/diffviewer/diffutils.py (Diff revision 1)
       
       
       
      Show all issues
      Probably should be one statement.
    3. reviewboard/diffviewer/diffutils.py (Diff revision 1)
       
       
       
      Show all issues
      Can just be one statement.
    4. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.6.x (dcb4710).
    BZ
    1. Ship It!
    2.