2784: Incorrect starred groups shown in sidebar on dashboard

matt.******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
Nov. 18, 2012
What version are you running?

1.6.13

What's the URL of the page containing the problem?

http://reviewboard.example.com/dashboard/


What steps will reproduce the problem?
1. Find a user who's user_id does not match his profile_id
2. Star a group with that user and see no groups show up on dashboard sidebar
3. Star a group with the user who's id is the same as the first user's profile_id and see that group show up on the first user's dashboard even though it was starred by the second user


What is the expected output? What do you see instead?

The starred groups should show up on that user's dashboard, not on the user who's user_id happens to match that user's profile_id.


What operating system are you using? What browser?

Server is on CentOS, client is Chrome on Windows 7.


Please provide any additional information below.

It looks like the filter for finding starred groups in get_sidebar_counts() in reviews/datagrids.py is looking for starred_by=user when it should be looking for groups that are starred by that user's profile.
david
#1 david
  • +PendingReview
  • +david
david
#2 david
Fixed in release-1.6.x (8ade17d). Thanks!
  • -PendingReview
    +Fixed