2335: post-review "basedir"

milan******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 19, 2012 
http://reviews.reviewboard.org/


What version are you running?
1.6.1

What's the URL of the page this enhancement relates to, if any?
localhost

Describe the enhancement and the motivation for it.
In post-review utility is unable to set basedir field for subversion diff upload.

What operating system are you using? What browser?
WindowsXP, IE7

Please provide any additional information below.
post-review --username=post-review --password=xyz --submit-as=milan.rusek --repository-url=svn+ssh://autobuild@czsrv-evcvs01/opt/svn/EFT --server=https://autobuild.wn-cz.local:8443 --summary="test review" --branch=EFT_0400_027 --revision-range=2007:2008 --basedir=branches/EFT_0400_027

But --basedir is not implemented there:-( Have you any idea how can I do it?

Best Regards,
Milan
david
#1 david 
There's no need for such an option, because post-review will automatically determine the basedir from your checkout.
  • +NotABug
#2 milan******@gmai***** (Google Code) (Is this you? Claim this profile.) 
It is not ok because without --basedir the post-review does not work with SVN diff files..

..or have you an idea how can I do it? Have you already try it in real SVN repository?

Milan
david
#3 david 
I suppose it might be necessary with --diff-filename, but if you're posting the change from an svn working directory, it will auto-detect it.
#4 eya***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I also want to use post-review --basedir, because the diff file is generated in a special logic, I do not want the post-review to auto check out the repository but to deal with an existing diff file... In such a situation, the basedir seems to be "/" all the time, that's absolutely a bug....
#6 j**@puresto******** (Google Code) (Is this you? Claim this profile.) 
This is absolutely a bug.  There's no way for me to upload a diff that's generated in a child directory of the svn repo without manipulating the diff to include all directories between the repo root and the base directory.

I know it's been stated that this is auto-detected, but if I want to upload a diff with no svn workspace (this is a very real use case with --diff-filename), I am stuck manipulating the diffs, which is not practical.  

I find it odd that the web interface has this working but the CLI no longer has a way of specifying the base dir.
chipx86
#7 chipx86 
Seems there are some legitimate use cases we should address.
  • -NotABug
    +Confirmed
  • +Component-RBTools
    +Milestone-RBTools-Release1.0
#8 smacleod 
Patch for review: http://reviews.reviewboard.org/r/3427/
#9 smacleod 
Fixed in master (7aaf87a002).
  • -Confirmed
    +Fixed