Add Github:Enterprise as a hosting service

Review Request #3376 — Created Sept. 29, 2012 and discarded

Information

Review Board

Reviewers

Hello,

I have been helping in the deployment of a Review Board installation at XING and we needed an easy way of handling GitHub:Enterprise repositories. It would be really good if you could add support for this hosting service in the future, as some companies are using it, so I have decided to send you the changes we have made to make it work.

As every GitHub:Enterprise installation has a different hostname and API URL, you need to add those values on a setting called HOSTINGSVCS, inside your settings_local.py. You can see an example of that setting on reviewboard/test.py.

Thank you.

 
Description From Last Updated

There's a lot of code duplication in this file. Can we instead subclass and make use of the original classes …

chipx86chipx86

This information should be in the forms. There should never be any need to access stuff from settings.

chipx86chipx86

This should only be set on the tests that need them.

chipx86chipx86
chipx86
  1. This would be a great addition, but some work needs to be done before we can accept it.
    1. Yes, I know it's an quick and dirty patch. I will see what I can do ;-)
  2. Show all issues
    There's a lot of code duplication in this file. Can we instead subclass and make use of the original classes in github.py?
  3. Show all issues
    This information should be in the forms. There should never be any need to access stuff from settings.
  4. reviewboard/test.py (Diff revision 1)
     
     
     
     
     
     
     
    Show all issues
    This should only be set on the tests that need them.
  5. 
      
ED
Review request changed
Status:
Discarded