Add links to issues shown on the dashboard

Review Request #3367 — Created Sept. 28, 2012 and submitted

Information

Review Board

Reviewers

Adds links to issues shown in the dashboard table/datagrid.

This review request updates r/3275, addressing the recommendations in that code review. 
Tested on local machine with custom and GitHub issue tracker urls. Also tested with malformed issue tracker urls.

Screenshots

david
  1. Can you add a screenshot?
  2. 
      
KA
  1. 
      
  2. Reused existing color for the links, but perhaps it should have it's own variable name?
    1. I think a separate variable name makes sense.
    2. How does @link-color sound? I've noticed a couple of places use #0000C0 blue for link text (e.g. email address on user pages (.email)), so perhaps the variable could be reused in those places as well.
    3. Sounds good to me.
    4. The navbar and other links are not necessarily the same color. The navbar's going to have a very different background from other places that may have links.
    5. Links are given their own LESS constant in r2. I just used #0000C0 to be consistent with some of the other links with a defined style, although many of the site anchors just use the browser default. If there's a better value to use, let me know -- the default for datagrid anchors seems to be black with no text decoration.
  3. 
      
KA
SM
  1. Might it be nice to see how this reacts with a large number of bugs, like 5-10?
    1. That's not any different than the current view, they just have underlines and are blue. I'm not sure why it wrapped it here, though.
    2. It only wraps if the window is too small or other more important columns are active -- the bugs column only gets a small chunk of real estate. Should it allow more than one per line?
  2. 
      
KA
david
  1. Ship It!
  2. 
      
KA
Review request changed
Status:
Completed
Change Summary:
Pushed to master (d196a3a). Thanks!