- Change Summary:
-
Convert .bind to .on in reviews.js.
WIP: jQuery 1.8.0
Review Request #3267 — Created Aug. 10, 2012 and submitted
Update the current jquery library to 1.8.0. This release is 13kbs larger than the currently used 1.3.2. (32kb vs 19kb) Some methods/functions used in RB might have been deprecated. See http://api.jquery.com/category/deprecated/. This update hosts all updates/improvements from 1.4 to 1.8. All release notes: 1.8: http://blog.jquery.com/2012/08/09/jquery-1-8-released/ 1.7: http://blog.jquery.com/2011/11/03/jquery-1-7-released/ 1.6: http://blog.jquery.com/2011/05/03/jquery-16-released/ 1.5: http://blog.jquery.com/2011/01/31/jquery-15-released/ 1.4: http://jquery14.com/day-01/jquery-14 Notable improvements: This update would bring in multiple performance improvements: - Faster selectors, events, and popular methods - Better cross-browser compatibility - Use of new methods and syntax Djblets might require an update as well.
Local dev. Things seem to be working so far. No errors. More testing to be done.
Description | From | Last Updated |
---|---|---|
This (and the other live() replacements in this change) don't look correct. In jQuery 1.7+, this should be done as: … |
chipx86 | |
In the dictionary-based on() cases, we shouldn't quote the names. |
chipx86 | |
Same comments here about dictionary-based event handling for on(). There's more uses like this in this change. |
chipx86 |
ME
- Change Summary:
-
Convert .bind to .on in all non-third-party RB .js files.
- Diff:
-
Revision 3 (+201 -195)
-
-
This (and the other live() replacements in this change) don't look correct. In jQuery 1.7+, this should be done as: $(document).on('click', this, ...); Second argument is the selector that live() was previously called on, and instead you use on() on $(document).
-
-
Same comments here about dictionary-based event handling for on(). There's more uses like this in this change.