Fix the order of displayed comments on a review.

Review Request #3249 — Created July 26, 2012 and submitted

Information

Review Board
release-1.6.x

Reviewers

Fix the order of displayed comments on a review.

Diff comments and replies were displayed in insert order rather than
timestamp order. This made things very confusing when comments were
created in orders other than top-down, or when replies were published in
orders other than the order created.

This was due to the ordering for diff comments not including the
timestamp, and instead taking into account only the filediffs and line
numbers. The timestamp is now factored in.

Fixes bug #2684
Unit test failed before the ordering change, but passed after.
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed