Summary

Bug Fix: JS var gDraftBanner not accessible globaly

Review Request #3182 — Created July 8, 2012 and submitted July 31, 2012, 3:25 a.m.

Information

Owner

medanat

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Globalize gDraftBanner by attaching it to the global RB object.

Testing Done

Can't test this locally, needs a non-dev deployment.

I'm realizing I'm now confused about the repro case. The minified files are also combined such that everything that would ever need this file would have the reviews.min.js loaded. I think I'd need to look into this more. Definitely need to be 100% sure this is fixing it.

medanat July 19, 2012, 6:51 a.m.

Was this bug ever fixed? I ran into it again today on r.rb.org.

It's not a matter of reviews.js not being loaded, it's the wrapper around reviews.js that isolates all internal definitions.

You could place review_request_dlgs.html within the reviews.js wrapper, that should probably fix it but possibly break other things.

chipx86 July 31, 2012, 3:25 a.m.

You're right. I was forgetting that pipeline "helpfully" wrapped our JavaScript to hide globals.

I've made one change to this, which is to assign to RB.draftBanner, instead of RB.gDraftBanner. The "g" prefix is meant for top-level globals, but isn't correct when assigned to something.

Status:: Completed
Change Summary:: Pushed to master (9c22446)