Summary

marked normal strings as translation strings

Review Request #309 — Created March 26, 2008 and submitted

Information

Owner

hfunai

Repository

Review Board SVN (deprecated)

Branch

Bugs

440

Depends On

Reviewers

Groups

reviewboard

People

Description

This change is only aimed to convert normal strings into translation strings.
Most of changes are template html files.

Testing Done

I confirmed all of the strings are translated which I changed on my local.

/trunk/reviewboard/templates/reviews/dashboard.html (Diff revision 1)

This line/file shouldn't be changed.

hfunai March 28, 2008, 10:54 a.m.

this is my mistake...
Hopefully this line could be translated in some ways.

/trunk/reviewboard/templates/reviews/review_reply.html (Diff revision 1)

Hrm.  This won't work so well for languages that don't put things in this order.

/trunk/reviewboard/templates/reviews/review_request_box.html (Diff revision 1)

Concatenation issues again.  This should translate the entire string at once (something like {% blocktrans %}Updated {{review...}} ago{% endblocktrans %})

Ship it!

Looks great.  Committed as r1241.  Thanks!

/trunk/reviewboard/templates/diffviewer/changeindex.html (Diff revision 2)

This doesn't work.  trans doesn't seem to expand {{ var }}.

chipx86 April 17, 2008, 10:05 a.m.

This has since been fixed. We caught the breakage shortly after it went in.