-
-
I'm not sure if this is the condition we should use. ['status'] is one of 'discarded', 'pending', or 'submitted'. I believe there is a valid use case where you would upload a new diff to a 'discarded' request, and then re-open it. As it stands, this change would require you to re-open the request before uploading the diff.
-
The indentation here looks a little funky to me, maybe you could try something like this: die("Review request %s is marked as %s. Updating is" "allowed only on pending requests." % ( options.rid, review_request['status']))
Bug fix: post-review creates unpublishable draft on submitted review requests
Review Request #3085 — Created April 29, 2012 and submitted
This fixes Issue:2549. I went with the first suggestion (not allowing updates), but I can also look into re-opening the issue upon publishing, if everyone likes that option better.
manual ran rbtools/tests.py (although they were mostly unrelated)
| Description | From | Last Updated |
|---|---|---|
|
I'm not sure if this is the condition we should use. ['status'] is one of 'discarded', 'pending', or 'submitted'. I … |
SM smacleod | |
|
The indentation here looks a little funky to me, maybe you could try something like this: die("Review request %s is … |
SM smacleod | |
|
One possible tiny optimization: review_request_status = server.get_review_request(options.rid)['status'] This way you'll avoid a double dict look-up. |
ME medanat | |
|
Couple small syntax-related comments. The text looks nicer if the space is after "is" instead of before "not". The text … |
 chipx86
|
|
|
Can you add an instruction here that if the user really wants to update it, they can reopen the review … |
 david
|
SM
-
-
Couple small syntax-related comments. The text looks nicer if the space is after "is" instead of before "not". The text is nicely aligned on the left that way. For the format parameters, the "(" should be right up against "options.rid". It can be on the following line, like: "blah blah" % (options.rid, status)
