Summary

Bug fix: Update comment issue status on a deleted screenshot

Review Request #3053 — Created April 9, 2012 and submitted June 2, 2012, 1:14 a.m.

Information

Owner

medanat

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This fixes a bug where an issue on a deleted screenshot can not have its status updated.

A possible fix has been proposed, confirmation is required. A test case to expose this scenario has also been created.

This bug may also be present with file attachments.

Testing Done

Ran reviewboard.webapi.tests:ReviewScreenshotCommentResourceTests.

11 Tests OK

Issues

Description	From	Last Updated
Seems like this would end up causing all comments to be returned, not just for this review request? Instead, I …	chipx86	May 3, 2012, 2:58 p.m.
Should be _delete_screenshot. (Yeah, the other functions need changing, but we'll do that at some point.)	chipx86	May 3, 2012, 2:58 p.m.

reviewboard/webapi/resources.py (Diff revision 1)

The issue has been resolved. Show all issues

Seems like this would end up causing all comments to be returned, not just for this review request?

Instead, I think you can do a Q(screenshot__review_request=) | Q(screenshot__inactive_review_request=)

medanat April 30, 2012, 4:51 a.m.

I'm not sure how to plug in those queries.

return self.model.objects.filter(screenshot__review_request=) || self.model.objects.filter(screenshot__inactive_review_request=)

Would that be correct?

david April 30, 2012, 11:29 a.m.

I think he means this:

return self.model.objects.filter(Q(screenshot__review_request=review_request) ||
                                 Q(screenshot__inactive_review_request=review_request),
                                 review__isnull=False)

chipx86 April 30, 2012, 10:48 p.m.
```
Except | instead of ||
```
ME

medanat May 3, 2012, 3:12 p.m.
```
Thanks David, Christian.
```

reviewboard/webapi/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Should be _delete_screenshot.

(Yeah, the other functions need changing, but we'll do that at some point.)

Change Summary:

Added suggested filter queries.

Diff:

Revision 2 (+79 -3)

Show changes

	reviewboard/webapi/resources.py
	reviewboard/webapi/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.6.x (4db1e57)