Summary

Caught DoesNotExist exceptions in WebAPI, now raises 404

Review Request #3040 — Created April 3, 2012 and discarded April 3, 2012, 8:37 p.m.

Information

Owner

ammok

Repository

Review Board

Branch

Bugs

2551

Depends On

Reviewers

Groups

reviewboard

People

Description

This addresses issue 2551.

Caught the DoesNotExist exceptions in the web API, and raised a HTTP 404 exception instead.
I tried to use the same language as in http://reviews.reviewboard.org/r/9999/

Testing Done

Testing done in Linux 3.2.13 with Chromium 18.0.

I visited local links that pointed to invalid review requests:
http://localhost:8080/api/review-requests/99/diffs/1/files/1/diff-comments/
http://localhost:8080/api/review-requests/999999999/screenshots/

Issues

Description	From	Last Updated
I'm not sure if this is the proper way to do this. I believe most other resources return a DOES_NOT_EXIST …	SM smacleod	April 3, 2012, 8:26 p.m.

Change Summary:

Reintroduced the spaces that I accidentally left out.

Diff:

Revision 2 (+9 -5)

Show changes

reviewboard/webapi/resources.py

Just something that jumped out at me right away.

reviewboard/webapi/resources.py (Diff revision 2)

The issue has been resolved. Show all issues

I'm not sure if this is the proper way to do this. I believe most other resources return a DOES_NOT_EXIST to 404 in cases like this. The fact that you needed an extra import also makes me think this isn't the right way.

ammok April 3, 2012, 8:26 p.m.

That makes sense.

This method is called by get_queryset, which is called by get_list in djblets as an argument of a response.
Unfortunately, the only way to catch the exception is by using the most generic django.core.exceptions.ObjectDoesNotExist.

So I'm going to close this review and open a new one.

Status:: Discarded