Review Bot
Review Request #3032 — Created March 31, 2012 and discarded
This is an initial prototype of Review Bot. Currently all configuration for the Review Board instance, message queue server, and user/password are manual in the code.
Description | From | Last Updated |
---|---|---|
Typo: Acknowledgements |
ME medanat | |
An empty line or two would be nice here. |
ME medanat | |
self._retried = self._lasturl == args[0] |
ME medanat | |
self._retried = response.code == 401 |
ME medanat | |
Is there a reason this is separate initialization call here? |
AM ammok | |
Should the '1.5.2' bit be pulled out into an explanatory constant? |
AM ammok | |
unreachable code? I don't think return True would get executed.. |
JI jimrrchen | |
return not cookie.is_expired() |
ME medanat | |
Does this still need to be handled? |
AM ammok | |
Will this method ever reach the end? Does it matter what it returns? |
AM ammok | |
Does this need to be a class variable? |
AM ammok | |
Would it be cleaner to set these values all at once? |
AM ammok | |
Would this be better off being done using HTTPError? http://www.tornadoweb.org/documentation/web.html#everything-else |
AM ammok |
AM
-
I've ignored some of the style things (e.g., one-line summaries) since this is prototype code.
-
This is more out of curiosity, but what is self.retried used for? I was looking at http://code.reddit.com/docs/urllib2-pysrc.html and it doesn't seem to mention it in the parents (though I suppose it doesn't preclude usage elsewhere).
-
-
-
-
-
-
-
-
Would this be better off being done using HTTPError? http://www.tornadoweb.org/documentation/web.html#everything-else