• 
      

    Protect the cookies file with a restrictive umask

    Review Request #2955 — Created March 11, 2012 and submitted

    Information

    RBTools
    master

    Reviewers

    Currently the .post-review-cookies file is created using the default
    system umask. On many UNIX systems this will create a file which is
    world-readable, thus potentially exposing the user's reviewboard
    credentials to any other user on that system.
    
    Setting the umask to 0077 should cause the file to be created with
    permissions 0600, i.e. readable only by the current user. This will
    only apply to new files and not existing ones.
    $ nosetests
    ..................SSSSSSThe --revision-range option is not supported for Perforce repositories.  Please use the Perforce range path syntax instead.
    
    See: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#posting-paths.............
    ----------------------------------------------------------------------
    Ran 37 tests in 14.594s
    
    OK (SKIP=6)
    
    The skipped tests are the Mercurial +svn tests for which I cannot seem to find the right combination of packages to run.
    david
    1. Ship It!
    2. 
        
    NA
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (29e13d8). Thanks!