• 
      

    Wrap calls to CVS inside a temporary directory

    Review Request #295 — Created March 13, 2008 and submitted

    Information

    Review Board SVN (deprecated)
    trunk

    Reviewers

    One mailing list user had problems with CVS, which seems to write a .cvsignore file to disk even though we use -p to write to stdout. This seems to break running reviewboard under apache.
    
    I don't know whether this actually fixed the problem or not, I just wanted to store the patch somewhere so it doesn't get lost.
    
    Update: Added new diff based on comments on diff 1.
    I've run the unit tests before and after, works without problems. I haven't been able to receive the same problem as the original op, hence I have no idea whether this actually changes anything :)
    david
    1. 
        
    2. trunk/reviewboard/scmtools/cvs.py (Diff revision 1)
       
       
      Trailing whitespace.  There are several places below, too.
    3. trunk/reviewboard/scmtools/cvs.py (Diff revision 1)
       
       
      It seems a little silly to have the bail_out function.  Just call cleanup() and raise the error directly.
    4. 
        
    david
    1. Looks good now.  Committed as r1238.
    2.