• 
      

    Datetime objects updated to check settings.USE_TZ

    Review Request #2949 — Created March 7, 2012 and submitted

    Information

    Djblets

    Reviewers

    Updated aware datetime objects to check settings.USE_TZ.
    Unit tests, pages that use these in RB dev server.
    Description From Last Updated

    Shouldn't django and djblets imports be separated?

    DD ddruska

    Mind getting rid of this blank line while you're here? These should be in the same section.

    chipx86chipx86

    Should be alphabetical. Before decorators.

    chipx86chipx86

    This is a Python module, so it must go first.

    chipx86chipx86
    DD
    chipx86
    1. 
        
      1. Shouldn't django and djblets imports be separated?
      2. No. They're both third-party modules not part of the current project.
    2. djblets/auth/util.py (Diff revision 2)
       
       
       
       
      Show all issues
      Mind getting rid of this blank line while you're here? These should be in the same section.
    3. djblets/auth/util.py (Diff revision 2)
       
       
      Show all issues
      Should be alphabetical. Before decorators.
    4. djblets/auth/util.py (Diff revision 2)
       
       
      Show all issues
      This is a Python module, so it must go first.
    5. 
        
    DD
    1. 
        
    2. djblets/auth/util.py (Diff revision 2)
       
       
       
       
      Show all issues
      Shouldn't django and djblets imports be separated?
    3. 
        
    DD
    DD
    chipx86
    1. Ship It!
    2. 
        
    DD
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (35517e1)