Summary

Fix handling of revisions with deleted files for SVN.

Review Request #2932 — Created March 3, 2012 and submitted March 4, 2012, 11:09 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

1113

Depends On

Reviewers

Groups

rbtools

People

Description

Fix handling of revisions with deleted files for SVN.

The implementation of post-review did the wrong thing when the SVN revision had
a deleted file. Posting the diff manually worked fine, so the bug was entirely
in the post-review side.

This patch has been kicking around in our bug tracker for more than a year, in
formats which made it very hard to review. Multiple posters there vouched that
it worked.

Fixes bug 1113.

Testing Done

This patch has been kicking around in our bug tracker for more than a year, in
formats which made it very hard to review. Multiple posters there vouched that
it worked.

Issues

Description	From	Last Updated
Should fix the camelCase.	chipx86	March 4, 2012, 11:05 a.m.
camelCase here too.	chipx86	March 4, 2012, 11:06 a.m.

I wish I better understood this change...

Anyway, styling-wise, camelCase should be fixed. Pointed out the cases.

rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should fix the camelCase.
```
rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
camelCase here too.
```

Description:

		Fix handling of revisions with deleted files for SVN.

		The implementation of post-review did the wrong thing when the SVN revision had
		a deleted file. Posting the diff manually worked fine, so the bug was entirely
		in the post-review side.
	+
	+	This patch has been kicking around in our bug tracker for more than a year, in
	+	formats which made it very hard to review. Multiple posters there vouched that
	+	it worked.
	+
	+	Fixes bug 1113.

Diff:

Revision 2 (+27 -8)

Show changes

	rbtools/clients/svn.py
	rbtools/utils/process.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f226c46).