Summary

Issue 106 -- visual commentary status on dashboard

Review Request #285 — Created Feb. 28, 2008 and submitted

Information

Owner

bretm

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Potential fix for:

http://code.google.com/p/reviewboard/issues/detail?id=106&sort=priority&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone
    
Visual indicator in the dashboard, per review, of your commentary status.
    
Uses the existing comment tag icons to represent the following states:
* no icon:  no comments
* blue (published): you've published comments and have no drafts waiting
* green (draft): you have at least one draft comment; this trumps published state

Testing Done

I've banged on it a bit, haven't found anything busted yet.

Screenshots

Here's what it looks like

These icons could work though we'd want smaller, scaled down versions. I'm not sure how clear these icons will be for this purpose. We might want some further discussion on this. Still, it's a good step :)

chipx86 March 31, 2008, 7:52 p.m.

Any progress on this? I'd love to get it in for 1.0.

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
Missing period.
```

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)

This is more of a developer comment than documentation. Can you move this out of the doc block and change it to comments? And probably put that in __init__?

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
sqlite
```

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)

Can you put _(...) around these to localize them?

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
Excess whitespace.
```

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)

It'd be nice to do the common parts of the filter once, like:

reviews = review_request.review_set.filter(user=user)

if reviews.filter(public=False).count() > 0:

trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
Can you convert to sentence case?
```
trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
_(...) here too.
```
trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
```
And _(...) here.
```

These icons could work though we'd want smaller, scaled down versions. I'm not sure how clear these icons will be for this purpose. We might want some further discussion on this. Still, it's a good step :)