Clean-up new API interface
Review Request #2845 — Created Feb. 8, 2012 and discarded
The legacy code is unstructured and it seems that noone has ever run it. Starting from this patch I will clean server interface until it becomes suitable for making HTTP requests. I intend to keep the chunks as small as possible in order to simplify the review process and speed-up acceptances, so some-times the logic may seem uncompleted.
Description | From | Last Updated |
---|---|---|
These comments say "list", but the default arguments are Python dicts. Also, maybe I'm not understanding this correctly - but … |
mike_conley | |
For NotImplementedError, it's not necessary to include a message unless it has some specific instructions. The current message just repeats … |
chipx86 | |
For the purposes of clarity, it'd be nice to keep what we had before where the results of raw_input and … |
chipx86 |
-
Seems reasonable, but I want to be sure that everything continues to work with this change?
-
For NotImplementedError, it's not necessary to include a message unless it has some specific instructions. The current message just repeats the purpose of the exception, so I wouldn't include anything at that point.
-
For the purposes of clarity, it'd be nice to keep what we had before where the results of raw_input and getpass are put into variables, and then returned. The reason being that each of these is a pretty hefty operation (block for input) and should be read as two operations rather than one operation where things are just returned.