Well done, that's a large chunk of code. Good hustle!

I pointed out a number of issues (mostly style), be sure to verify each one and double check the correctness of the code afterwards. 

I would also suggest running a PEP8 guide checker on your code:

PEP8: http://www.python.org/dev/peps/pep-0008/
PEP8 guide checker: http://pypi.python.org/pypi/pep8

Thanks!

-Yazan 

The convention is to have imports in alphabetical order.

this could be: 

return response[0].lower() == 'y' 

This could be:

return bool(re.match(self.REGEX, string))

I'm not a huge fan of this approach to looping.

Maybe use an iterator here?

iterator = (word.capitalize() for word in string.split(" "))

and then get words using iterator.next()

This is simply an opinion, and not a correctness issue.

You can use the bool() function here again.

This could be:

return re.match(r'^[a-z]', string) != None

This may not be very readable. Consider breaking it into multiple lines.

This could be:

if string:

Since None and the empty string have the same boolean value of False in Python.

This could be: (I'm not 100% sure on this one)

if not options.description:

Leave a space between imports and code body.

Again,

if dashboard_link

Also, why are you prefixing the tags with hyphens?

Again, if dashboard_link

This would be:

URLHook(extension, pattern)

Same init issue:

Class(arg1, ...)

init issue again.

I'm not sure what's going on here with the template tags:

{{'{%'}}

Is there a reason you're doing it this way rather than {% statement %}?

Place this in a trans block.

Place "To do..." in trans block.

These could be on the same line.
Also, it seems that there's an extra single space before "To do..."

"To do..." can also be placed in a trans block.

Not sure if this applies in template pages, but this could be:

{% if dashboard_link %}

Consider adding the an all caps case?

Isn't the comma at the end of this string a syntax error? 

PEP 8 seems to recommend that we explicitly check to see if it "is None".

It might be a bit unclear (should I add a '.template' suffix to these files?), but this uses Jinja. The dashes suppress whitespace.

It seems the suggested idiom for calling a superconstructor is to use something like super(ExtensionURLHook, self).__init__(arg1) (it's also used a few times in the reviewboard code)

Yes. This is because otherwise Jinja will interpret it as Jinja templating rather than raw text: http://jinja.pocoo.org/docs/templates/#escaping

The indentation for plain text in the HTML templates seems to be either one space or 2 spaces.

The line above it already ended with a comma. It always looked like an error to me but I can see the sense in keeping it as it allows you to easily add and remove individual lines anywhere in the list without worrying about commas.

Anthony:

This is looking really good!  Just a few issues below.

Thanks for your work,

-Mike

We'll want some documentation for this function, and the various classes / functions below.

I wonder if it'd be clearer if the flow for the unrecognized input case was as follows:

1) Ask the user the question
2) User answers with something invalid
3) Tell the user that their input was unrecognized
4) Go to (1)

This way, it's clearer what question the user is being asked to answer.

--dashboard-link is optional - we should mention that in its help information.

If I supply no arguments, I get:

incorrect number of arguments
Traceback (most recent call last):
  File "/usr/local/bin/rb_extgen", line 9, in <module>
    load_entry_point('RBTools==0.4alpha0.dev', 'console_scripts', 'rb_extgen')()
  File "/media/Projects/rbtools/rbtools/rb_extgen.py", line 157, in main
    parse_options()
  File "/media/Projects/rbtools/rbtools/rb_extgen.py", line 101, in parse_options
    options.extension_name = args[0]
IndexError: list index out of range


We should probably do something more helpful here, like display the help.

Newlines above and below this for block.

This template is missing from your patch.

Nice tests!

Looking good! As Mike has noted, some documentation/comments would go a long way.

Good job!

Possibly place this variable within __init__

Same thing, place within __init__

Same thing, place within __init__

Nitpicking here:

{%- if dashboard_link is not none%}

Add a single space after none

All this could be wrapped within the same:

{%- if dashboard_link is not none %}

{%- endif %}

Wrap within same if statement.

This doesn't belong in RBTools. RBTools is meant to be used to talk to a Review Board server, but not for developing. This might be better suited as something in reviewboard/contrib/. We could probably build a package out of it later, or move it out to its own module.

A bit of stuff here. Mostly style-related, which you'll get the hang of. Also some pythonisms.

jinja2 is a third-party module, and belongs in a group after the built-in Python modules.

Same.

Two blank lines here.

No need for the parens around question.

No need for the len() check, I don't think.

Blank line between these.

Classes should always at least inherit from 'object'):

class NamingConvention(object):

Should use re.compile().

The regex should be pulled out into a compiled regex in the class.

This can be one statement.

Make this part of the class, and compile it.

One statement.

This can be simplified to:

if string:
    string = ...
elif case.formatted(string):
    return

Blank line between these.

Blank line between these.

Blank line between these.

Basically: Blank line before/after a block of code.

Inherit from object.

Should use the os.path stuff to parse the path.

Use os.path.join instead.

No need for parens when it's just one thing in the format arguments.

Blank line.

Use 'f', not 'FILE'. No uppercase unless it's a constant.

Blank line.

Blank line.

Blank line.

Two blank lines.

Should use Django's url() stuff.

Two blank lines.

__init__ should take *args, **kwargs, and the super() should pass it. That allows us to expand down the road without breaking things.

The URLs should be indented only 4 spaces, and use the url() stuff.

Also, two blank lines above this.

Two blank lines.

If we're not providing any sort of default arguments, no need for the {} param to RequestContext.

Should only be indented 4 spaces.

Two blank lines.

Single quotes are fine.

Either one line, or indent the value by 4 spaces.