Ok, sounds nice; so do you need that I do anything else on my side? Appart from testing the plugin as soon as it gets integrated, of course.

Yeah, if you can just merge the latest from RBTools master into your change and update the review request, I can apply it and push it upstream.

All right, I'll try to do it today if possible. I'll let you know as soon as it's done.

Thanks!

Hi, Christian:

These are the steps I followed:
$ git fetch upstream
$ git merge upstream/master
$ git checkout --ours rbtools/clients/plastic.py (to keep my changes)
$ git add rbtools/clients/plastic.py
$ git commit -m "using my changes in the plugin"
$ git pull origin master

Then I tried again a fetch and everything was up to date :-)

Now I have to update the review; I did:
$ postreview.py
Traceback (most recent call last):
  File "./postreview.py", line 1307, in <module>
    main()
  File "./postreview.py", line 1211, in main
    args = parse_options(sys.argv[1:])
  File "./postreview.py", line 967, in parse_options
    default=get_config_value(configs, 'PUBLISH', False),
TypeError: get_config_value() takes exactly 2 arguments (3 given)

But I don't remember what the parameters were :-(

Maybe I don't have to create a new review, but update this existing one...

Could you please help me?

Another question: will you integrate the changes in the rbtools repository as well as the ones included in the reviewboard repository? Both changes are necessary...

Best,
Luis

I forgot to say that I was using the py script that I downloaded from the repository. I think that this was what I did the last time I posted a review.

Update:

I found this in the web page:
http://www.reviewboard.org/docs/codebase/dev/getting-started/

and tried this:
$ postreview.py -r 2798
Traceback (most recent call last):
  File "./postreview.py", line 1307, in <module>
    main()
  File "./postreview.py", line 1211, in main
    args = parse_options(sys.argv[1:])
  File "./postreview.py", line 967, in parse_options
    default=get_config_value(configs, 'PUBLISH', False),
TypeError: get_config_value() takes exactly 2 arguments (3 given)

But still I am doing something wrong :-(

It looks like you have an older version of rbtools installed on the system. You'll have to install the new one, not just download postreview.py

Ping?