Summary

Fix issues with server authentication when anonymous is disabled

Review Request #2776 — Created Jan. 1, 2012 and submitted Sept. 29, 2012, 1:22 p.m.

Information

Owner

stid

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Fix issue 2429 and issue 2430
 * Do not try to connect server if post-review is issued with '--output-diff'
 * Use relative url to get the api info in case the server is behind a reverse proxy, such as nginx

Testing Done

Description:: ~
Fix issue #2429 and #2430:
~
Fix issue #2429 and issue #2430
* Do not try to connect server if post-review is issued with '--output-diff'
* Log on the server before fetching the API info from the server

Description:: ~
Fix issue #2429 and issue #2430
~
Fix issue 2429 and issue 2430
* Do not try to connect server if post-review is issued with '--output-diff'
* Log on the server before fetching the API info from the server

Diff:

Revision 2 (+21 -16)

Show changes

rbtools/postreview.py

Description:: Fix issue 2429 and issue 2430
* Do not try to connect server if post-review is issued with '--output-diff'
~ * Log on the server before fetching the API info from the server
~ * Use relative url to get the api info in case the server is behind a reverse proxy, such as nginx

rbtools/postreview.py (Diff revision 2)

Since we've already have a workaround in issue 2430, this block is actually not necessary.

Status:: Completed
Change Summary:: Pushed to master (7d0026f). Thanks!

~		Fix issue #2429 and #2430:
	~	Fix issue #2429 and issue #2430
		* Do not try to connect server if post-review is issued with '--output-diff'
		* Log on the server before fetching the API info from the server

~		Fix issue #2429 and issue #2430
	~	Fix issue 2429 and issue 2430
		* Do not try to connect server if post-review is issued with '--output-diff'
		* Log on the server before fetching the API info from the server