Informative error message on not being able to locate GNU diff in a Perforce workspace

 






 

 


  Review Request #2685
  —
  Created Nov. 4, 2011 and submitted 

 


















 

  

   Information

  





 
 

  Faller.Gyula
 









 
 

  RBTools
 









 
 

  release-0.3.x
 









 
 

  2352
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  chipx86
 






 








 





  


 
 

  
Currently, if no GNU diff in the path, post-review gives an unhandled exception and a call stack. It scares the user, and left him without any clue what is wrong.
I found this is solved in case of SVN so I ported that solution to Perfoce too.
(This patch sould be applied to the master too.)

 








  


 
 

  

 







 









 





  








 









 






  

 








 














 



 

  

   





 FA





   

   

  

 



 















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 FA





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-0.3.x (b6130ec) and master (ab4ad64). Thanks!