Added support for multiple admins
Review Request #2670 — Created Oct. 23, 2011 and discarded — Latest diff uploaded
* Admins names and emails can be added and removed through admin UI. * New User registration emails will send to all admins. This patch go with another patch in djblet: http://reviews.reviewboard.org/r/2671/
Unit tested. The result looks good except some failure due to Windows environment. Manually test: * Manually added and removed admins in FF, Chrome, and IE. Worked as expected. * Ran "prepare-dev.py", admins settings was migrated properly. * Registered a new user, email notifications sent to all admins.
Running dependency checks (set DEBUG=False to turn this off)...
Warning: hg not found. Mercurial integration will not work.
Warning: bzrlib not found. Bazaar integration will not work.
Warning: PyLucene (with JCC) is required to enable search. See the documentation for instructions.
Warning: mtn binary not found. Monotone integration will not work.
Please see http://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.
C:\Python25\lib\site-packages\Crypto\Util\randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken
RandomPool_DeprecationWarning)
Testing User.is_profile_public with private profiles. ... ok
Testing User.is_profile_public with public profiles. ... ok
Testing if star, unstar affect review request counts correctly. ... ok
Testing check_updates_required with valid configuration ... ok
Testing check_updates_required with bad m
Diff Revision 2 (Latest)
orig
1
2
| reviewboard/admin/forms.py |
|---|
| reviewboard/admin/siteconfig.py |
|---|
| reviewboard/admin/urls.py |
|---|
| reviewboard/admin/views.py |
|---|
| reviewboard/admin/management/sites.py |
|---|
| reviewboard/cmdline/rbsite.py |
|---|
| reviewboard/htdocs/media/rb/css/admin.css |
|---|
| reviewboard/notifications/tests.py |
|---|
| reviewboard/templates/admin/dynamic-formset.js |
|---|
| reviewboard/templates/admin/site_admins_settings.html |
|---|
| reviewboard/templates/admin/widgets/w-actions.html |
|---|