-
-
-
-
-
"Add" Actually, it'd be nice to have this be somewhat dynamic so that there's always one more row of blank values. That'd remove the need for "Add" and instead there'd just be fields to type into. Much better user experience.
-
-
-
This can instead be: initial_data = [ { 'site_admin_name': admin[0], 'site_admin_email': admin[1], } for admin in admins ] -
-
-
-
-
-
-
-
-
-
the href should be "#". javascript: URLs are deprecated and not even supported in modern browsers. Also, localize the text.
-
Added support for multiple admins
Review Request #2670 — Created Oct. 23, 2011 and discarded
* Admins names and emails can be added and removed through admin UI. * New User registration emails will send to all admins. This patch go with another patch in djblet: http://reviews.reviewboard.org/r/2671/
Unit tested. The result looks good except some failure due to Windows environment. Manually test: * Manually added and removed admins in FF, Chrome, and IE. Worked as expected. * Ran "prepare-dev.py", admins settings was migrated properly. * Registered a new user, email notifications sent to all admins.
Running dependency checks (set DEBUG=False to turn this off)...
Warning: hg not found. Mercurial integration will not work.
Warning: bzrlib not found. Bazaar integration will not work.
Warning: PyLucene (with JCC) is required to enable search. See the documentation for instructions.
Warning: mtn binary not found. Monotone integration will not work.
Please see http://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.
C:\Python25\lib\site-packages\Crypto\Util\randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken
RandomPool_DeprecationWarning)
Testing User.is_profile_public with private profiles. ... ok
Testing User.is_profile_public with public profiles. ... ok
Testing if star, unstar affect review request counts correctly. ... ok
Testing check_updates_required with valid configuration ... ok
Testing check_updates_required with bad m
| Description | From | Last Updated | ||
|---|---|---|---|---|
|
This would just be good as "Name." |
 chipx86
|
|||
|
"E-mail Address" |
chipx86
|
|||
|
"Delete" |
chipx86
|
|||
|
"Add" Actually, it'd be nice to have this be somewhat dynamic so that there's always one more row of blank … |
chipx86
|
|||
|
Should derive from object. |
chipx86
|
|||
|
Should be initial_data instead of initVals. No CamelCase. |
chipx86
|
|||
|
This can instead be: initial_data = [ { 'site_admin_name': admin[0], 'site_admin_email': admin[1], } for admin in admins ] |
chipx86
|
|||
|
All one line. |
chipx86
|
|||
|
All one line. |
chipx86
|
|||
|
Blank line between these. The setting of "admins" should probably be grouped with the save call. |
chipx86
|
|||
|
Blank line between the block and apply_setting. Should group the two apply_settings together. |
chipx86
|
|||
|
SSHSettingsForm should be indented along with AdminsFormSetManager. |
chipx86
|
|||
|
Store site_config separately and pass it in. It'll make for nicer code. |
chipx86
|
|||
|
Is this part of this change? |
chipx86
|
|||
|
Should be localized. |
chipx86
|
|||
|
No space in {{variables}} |
chipx86
|
|||
|
the href should be "#". javascript: URLs are deprecated and not even supported in modern browsers. Also, localize the text. |
chipx86
|
|||
|
Same comments about href and localization. |
chipx86
|
|||
| There are no open issues | ||||
HO
- Change Summary:
-
Thanks for review. Changed according to comments of the review.
- Description:
-
- Admins names and emails can be added and removed through admin UI.
- New User registration emails will send to all admins.
- - Imported "with" statement in order to fix an syntax error, when RB runs on python 2.5.
This patch go with another patch in djblet:
http://reviews.reviewboard.org/r/2671/ - Diff:
-
Revision 2 (+190 -30)
- Screenshots:
-