Summary

Make modern versions of our old backup/load scripts.

Review Request #2669 — Created Oct. 22, 2011 and submitted Feb. 10, 2012, 6:13 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Make modern versions of our old backup/load scripts.

The DB backup/load scripts are still around, but don't cover all models.
It's worth fixing up, since they can be useful when moving from sqlite
to something else.

They've been moved to be management commands now. This will be made
available to 1.6.

Testing Done

Did some sample backups and loads of my DB. I think it got everything.

Issues

Description	From	Last Updated
This should point out that it dumps to stdout.	david	Nov. 6, 2011, 4:49 a.m.
This should be a list comprehension: models = [get_models(app) for app in get_apps()]	david	Nov. 6, 2011, 4:49 a.m.
It would be nice to only count these once. counts = [model.objects.count() for model in models] for model, count in …	david	Nov. 4, 2011, 4:45 a.m.
Doesn't need ()s	david	Nov. 6, 2011, 4:51 a.m.
These can be combined	david	Nov. 6, 2011, 4:51 a.m.

Fix it!

reviewboard/admin/management/commands/dumpdb.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should point out that it dumps to stdout.
```
reviewboard/admin/management/commands/dumpdb.py (Diff revision 1)
The issue has been dropped. Show all issues
```
This should be a list comprehension:

models = [get_models(app) for app in get_apps()]
```
1. chipx86 Nov. 6, 2011, 4:51 a.m.
  Extending, not appending.

reviewboard/admin/management/commands/dumpdb.py (Diff revision 1)

An issue was opened. Show all issues

It would be nice to only count these once.

counts = [model.objects.count() for model in models]
for model, count in zip(models, counts):
    ...

chipx86 Nov. 6, 2011, 4:51 a.m.

It's still a query per count. I don't think it makes any difference? It's just a question of do we do the queries all up-front, or when it comes time to serialize the model.

reviewboard/admin/management/commands/dumpdb.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Doesn't need ()s
```
reviewboard/admin/management/commands/dumpdb.py (Diff revision 1)
The issue has been resolved. Show all issues
```
These can be combined
```

Change Summary:

* Changed some text.
* Style stuff.

Diff:

Revision 2 (+160 -408)

Show changes

	contrib/db/backup-db.py
	contrib/db/db2wiki.py
	contrib/db/load-db.py
	reviewboard/admin/management/commands/dumpdb.py
	reviewboard/admin/management/commands/loaddb.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.6.x (7fe956a06a114e44cfdb5291a2059805d3ca01a6)