Cache diff fragments by URL and preserve diff options while paging
Review Request #2652 — Created Oct. 10, 2011 and discarded — Latest diff uploaded
Thess changes take all the diff viewing options (syntax highlighting, expand/collapse) and embeds them into the URL of the diff fragment (instead of relying on cookies). This accomplishes two things - one, we now preserve diff preference as we page around the diff, and two, individual diff fragments can now be entirely cached by their URL using the @cache_page directive. On GitHub as individual commits: https://github.com/bhollis/reviewboard/commit/f5268174871ab5f5f30d560e592d2e53570d5780 https://github.com/bhollis/reviewboard/commit/58a2c8c6dc22b49e56e2e6cd4dc1d2367c412a93 https://github.com/bhollis/reviewboard/commit/4fc6775b62aa66b391dc9e95789b0f3891226d93
Used on our own RB instance
Diff Revision 1 (Latest)
| reviewboard/diffviewer/views.py |
|---|
| reviewboard/htdocs/media/rb/js/datastore.js |
|---|
| reviewboard/htdocs/media/rb/js/diffviewer.js |
|---|
| reviewboard/reviews/views.py |
|---|
| reviewboard/templates/diffviewer/changeindex.html |
|---|
| reviewboard/templates/diffviewer/diff_file_fragment.html |
|---|
| reviewboard/templates/diffviewer/view_diff.html |
|---|